Skip to content

azure-cli: migrate to python@3.9#78022

Closed
bsiegel wants to merge 1 commit intoHomebrew:masterfrom
bsiegel:master
Closed

azure-cli: migrate to python@3.9#78022
bsiegel wants to merge 1 commit intoHomebrew:masterfrom
bsiegel:master

Conversation

@bsiegel
Copy link
Copy Markdown
Contributor

@bsiegel bsiegel commented May 25, 2021 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label May 25, 2021
@bsiegel bsiegel marked this pull request as ready for review May 25, 2021 20:18
carlocab
carlocab requested changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @bsiegel. However, I believe azure-cli isn't compatible with Python3.9 yet. (e.g. Azure/azure-cli#15580)

azure-cli's automated release workflow will just switch this back to Python3.8 at the next version bump. See:

https://github.com/Azure/azure-cli/blob/dev/scripts/release/homebrew/docker/formula_template.txt
Azure/azure-cli#15482
#62253
#62785

@bsiegel
Copy link
Copy Markdown
Contributor Author

bsiegel commented May 25, 2021 •
edited
Loading

Ah, okay. The tracking issue for Python 3.9 support (Azure/azure-cli#16611) was closed and the release notes for 2.24.0 mention Python 3.9 support so I believe the tool itself is now ready for Python 3.9. However as you point out the automation seems like it will just overwrite this change, so it sounds like the right thing to do will be to open a PR to update the automation in the azure-cli repo.

@bsiegel
Copy link
Copy Markdown
Contributor Author

bsiegel commented May 25, 2021

I've opened Azure/azure-cli#18224 to update the formula template

@carlocab
Copy link
Copy Markdown
Member

carlocab commented May 25, 2021

Great, this should be good then once Azure/azure-cli#18224 is merged. Thanks for working on that.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Jun 1, 2021

This needs rebasing after #78459. (With git rebase and not git merge, please. Apologies if that's obvious--I've seen others use git merge to rebase before.)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 23, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jun 23, 2021
@bsiegel
Copy link
Copy Markdown
Contributor Author

bsiegel commented Jun 23, 2021

Still pending merge of the blocking PR in the azure-cli repo. Looks like it -may- be scheduled for completion this month.

@carlocab carlocab added in progress Stale bot should stay away upstream issue An upstream issue report is needed and removed stale No recent activity labels Jun 23, 2021
@cho-m cho-m mentioned this pull request Aug 11, 2021
Closed
@jiasli
Copy link
Copy Markdown

jiasli commented Aug 13, 2021

We have merged Azure/azure-cli#18224. Please go ahead and merge this PR. Thanks!!

@jiasli jiasli mentioned this pull request Aug 13, 2021
Merged
carlocab
carlocab previously approved these changes Aug 13, 2021
View reviewed changes
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Aug 13, 2021

:shipit: @carlocab has triggered a merge.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Aug 13, 2021

Thanks, @bsiegel, @jiasli!

@jiasli jiasli mentioned this pull request Aug 13, 2021
Merged
3 tasks
@BrewTestBot
Copy link
Copy Markdown
Contributor

BrewTestBot commented Aug 13, 2021

⚠️ @carlocab bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review August 13, 2021 14:00

bottle publish failed

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Aug 13, 2021

Oops, this doesn't work. Let me try something else.

@carlocab
Copy link
Copy Markdown
Member

carlocab commented Aug 13, 2021

Cherry-picked the changes here onto #83088.

@carlocab carlocab closed this Aug 13, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carlocab carlocab carlocab left review comments

Assignees

No one assigned

Labels

in progress Stale bot should stay away outdated PR was locked due to age python Python use is a significant feature of the PR or issue upstream issue An upstream issue report is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bsiegel @carlocab @jiasli @BrewTestBot